feat(app): Always show search for small screens & mobile#13686
feat(app): Always show search for small screens & mobile#13686DNGriffin wants to merge 2 commits into
Conversation
|
Thanks for your contribution! This PR doesn't have a linked issue. All PRs must reference an existing issue. Please:
See CONTRIBUTING.md for details. |
|
The following comment was made by an LLM, it may be inaccurate: I found one potentially related PR: PR #7989: fix(app): comprehensive mobile UX improvements Why it might be related: This PR also addresses mobile UX improvements. It could be related to your search visibility changes on mobile, though it appears to be broader in scope. Worth checking if it already covers or conflicts with your search header changes. |
| <Icon name="magnifying-glass" size="normal" class="icon-base shrink-0" /> | ||
| <Icon name="magnifying-glass" size="normal" class="icon-base shrink-0" /> | ||
| <span class="md:hidden text-14-regular text-text-weak"> | ||
| {language.t("common.search.placeholder")} |
There was a problem hiding this comment.
Adds this new span to not show project name in the string. (other one is "Search {ProjectName}" but this is just "Search"
Alternatively we could do ellipses on the existing string
| <Show when={hotkey()}> | ||
| {(keybind) => ( | ||
| <Keybind class="shrink-0 !border-0 !bg-transparent !shadow-none px-0">{keybind()}</Keybind> | ||
| <Keybind class="hidden md:flex shrink-0 !border-0 !bg-transparent !shadow-none px-0">{keybind()}</Keybind> |
There was a problem hiding this comment.
Hides keybind on smaller screens.
The keybind doesn't work on mobile & header space is in high demand at this smaller breakpoint.
DNGriffin
force-pushed
the
dg/mobile-search
branch
from
a1265da to
b127cc4
Compare
|
Closing this pull request because it has had no updates for more than 60 days. If you plan to continue working on it, feel free to reopen or open a new PR. |
1 participant
What does this PR do?
This PR makes search always visible in the header for mobile. Mobile doesn't have hotkeys (or gestures), so the only way to do a lot of things is with buttons or search.
Before:
After:
How did you verify your code works?
Tested it on chrome emulator & phone, and validated that the existing large desktop search UX remains unchanged visually.
Closes: #13685